Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scanner max buffer size in env collector #626

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

adambabik
Copy link
Collaborator

The solution is to provide a custom buffer to the scanner in the env collector. Effectively, it is a port from runnerv1 with a better initial buffer size.

Closes #624

@adambabik adambabik marked this pull request as ready for review July 4, 2024 22:26
@adambabik adambabik force-pushed the adamb/fix-env-collector-scanner-buffer-size branch from 2b418f3 to 42d828f Compare July 4, 2024 22:27
Copy link

sonarcloud bot commented Jul 4, 2024

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@sourishkrout sourishkrout merged commit 079ee03 into main Jul 6, 2024
7 checks passed
@sourishkrout sourishkrout deleted the adamb/fix-env-collector-scanner-buffer-size branch July 6, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"bufio.Scanner: token too long" after large binary stream
2 participants